Skip to content

Add --output-format json for Rustdoc on nightly #74955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2020
Merged

Add --output-format json for Rustdoc on nightly #74955

merged 1 commit into from
Jul 31, 2020

Conversation

P1n3appl3
Copy link
Contributor

This enables the previously deprecated --output-format flag so it can be used on nightly to host the experimental implementation of rfc/2963. The actual implementation will come in later PRs so for now there's just a stub that gives you an ICE.

I'm pretty sure that the logic I added makes it inaccessible from stable, but someone should double check that. @tmandry @jyn514

@rust-highfive
Copy link
Contributor

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 30, 2020
tmandry
tmandry approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@tmandry tmandry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Someone on the rustdoc team should take a look also.

@tmandry
Copy link
Member

tmandry commented Jul 30, 2020

cc @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

Looks good to me, thanks!

r=me once CI passed

@tmandry
Copy link
Member

tmandry commented Jul 30, 2020

@bors r=GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Jul 30, 2020

📌 Commit 48c6f05 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2020
@tmandry
Copy link
Member

tmandry commented Jul 30, 2020

@bors rollup=always

@bors
Copy link
Collaborator

bors commented Jul 31, 2020

⌛ Testing commit 48c6f05 with merge 66b97dc...

@bors
Copy link
Collaborator

bors commented Jul 31, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: GuillaumeGomez
Pushing 66b97dc to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 31, 2020
@bors bors merged commit 66b97dc into rust-lang:master Jul 31, 2020
@MOZGIII MOZGIII mentioned this pull request Sep 3, 2020
Closed
@aDotInTheVoid
Copy link
Member

@rustbot modify labels +A-rustdoc-json

@rustbot rustbot added the A-rustdoc-json Area: Rustdoc JSON backend label Jan 24, 2021
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmandry tmandry tmandry approved these changes

Assignees

@steveklabnik steveklabnik

Labels
A-rustdoc-json Area: Rustdoc JSON backend merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
9 participants
@P1n3appl3 @rust-highfive @tmandry @GuillaumeGomez @bors @aDotInTheVoid @steveklabnik @cuviper @rustbot